Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
dshin-moz
reviewed
Sep 4, 2026
| ) -> StylesheetInvalidationSet { | ||
| let (flusher, mut invalidations) = self.stylesheets.flush(); | ||
| // TODO(emilio): We don't collect invalidations for shadow trees, see | ||
| // Servo_StyleSet_FlushStyleSheets. |
Contributor
There was a problem hiding this comment.
Nit: Maybe "for same reasons as specified in Servo_StyleSet_FlushStyleSheets?"
dshin-moz
reviewed
Sep 4, 2026
| } | ||
|
|
||
| /// Collects invalidations for the sheets that have been added since the | ||
| /// last flush. Sheets that are added and removed before a flush don't |
Contributor
There was a problem hiding this comment.
Later part of this comment seems to belong in Line 401?
dshin-moz
reviewed
Sep 4, 2026
dshin-moz
reviewed
Sep 4, 2026
dshin-moz
reviewed
Sep 4, 2026
dshin-moz
approved these changes
Sep 4, 2026
We already keep track of whether a stylesheet has been committed or not, so this patch: * Avoids collecting invalidations for removals that haven't made it to the document. * Avoids collecting invalidations for insertions that get removed too early. This helps with bug 2065622, because most of the time in invalidation there is just useless.
emilio
force-pushed
the
lazy-invalidation
branch
from
September 4, 2026 15:58
0f7b4b2 to
19d10eb
Compare
dshin-moz
approved these changes
Sep 4, 2026
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 4, 2026
We already keep track of whether a stylesheet has been committed or not, so this patch: * Avoids collecting invalidations for removals that haven't made it to the document. * Avoids collecting invalidations for insertions that get removed too early. This helps with bug 2065622, because most of the time in invalidation there is just useless. Pull request: #358
|
Pull request closed by commit ca0576f |
github-actions Bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Sep 5, 2026
We already keep track of whether a stylesheet has been committed or not, so this patch: * Avoids collecting invalidations for removals that haven't made it to the document. * Avoids collecting invalidations for insertions that get removed too early. This helps with bug 2065622, because most of the time in invalidation there is just useless. Pull request: mozilla-firefox/firefox#358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already keep track of whether a stylesheet has been committed or not,
so this patch:
the document.
early.
This helps with bug 2065622, because most of the time in invalidation
there is just useless.
Lando: link
Bugzilla: bug 2069393
🚫 This pull request has 1 blocker.