Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
emilio
force-pushed
the
highlight-restrictions
branch
from
September 4, 2026 11:58
320509d to
b3db60c
Compare
dshin-moz
suggested changes
Sep 4, 2026
dshin-moz
left a comment
Contributor
There was a problem hiding this comment.
Don't think webkit text properties are allowed, are they?
Otherwise the change looks good - seems to be mostly refactoring Option<PropertyFlags> to be just PropertyFlags, since that's a bitfield and can be empty
…ascade time. r=#style Matches Chrome and the spec in terms of em / lh units etc, and prevents border-radius to set the border-background flag without extra tracking.
emilio
force-pushed
the
highlight-restrictions
branch
from
September 4, 2026 13:25
b3db60c to
144eedf
Compare
dshin-moz
approved these changes
Sep 4, 2026
|
Pull request closed by commit b9c51f5 |
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 4, 2026
…ascade time. r=dshin Matches Chrome and the spec in terms of em / lh units etc, and prevents border-radius to set the border-background flag without extra tracking. Pull request: #357
github-actions Bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Sep 5, 2026
…ascade time. r=dshin Matches Chrome and the spec in terms of em / lh units etc, and prevents border-radius to set the border-background flag without extra tracking. Pull request: mozilla-firefox/firefox#357
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 6, 2026
…ascade time. a=dmeehan Matches Chrome and the spec in terms of em / lh units etc, and prevents border-radius to set the border-background flag without extra tracking. Pull request: #357 Differential Revision: https://phabricator.services.mozilla.com/D323847
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 6, 2026
…ascade time. a=dmeehan Matches Chrome and the spec in terms of em / lh units etc, and prevents border-radius to set the border-background flag without extra tracking. Pull request: #357 Differential Revision: https://phabricator.services.mozilla.com/D323848
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 7, 2026
Matches Chrome and the spec in terms of em / lh units etc, and prevents border-radius to set the border-background flag without extra tracking. Pull request: mozilla-firefox/firefox#357 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2066814 gecko-commit: 9de51bc60b4affba54a5ad608a58ba06029fd64a gecko-commit-git: b9c51f59c975365d9cd7799cb2f5d1027a4a8a64 gecko-reviewers: dshin
openresearchtools
pushed a commit
to openresearchtools/BashKitten
that referenced
this pull request
Sep 22, 2026
…ascade time. a=dmeehan Matches Chrome and the spec in terms of em / lh units etc, and prevents border-radius to set the border-background flag without extra tracking. Pull request: mozilla-firefox/firefox#357 Differential Revision: https://phabricator.services.mozilla.com/D323848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.
Lando: link
Bugzilla: bug 2066814
🚫 This pull request has 1 blocker.