Skip to content

Bug 2066814 - Restrict the properties that highlight pseudos get at cascade time. r=#style - #357

Closed
emilio wants to merge 1 commit into
mozilla-firefox:autolandfrom
emilio:highlight-restrictions
Closed

emilio wants to merge 1 commit into
mozilla-firefox:autolandfrom
emilio:highlight-restrictions

Conversation

@emilio

@emilio emilio commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.


Lando: link
Bugzilla: bug 2066814

⚠️ This pull request has 6 warnings.
🚫 This pull request has 1 blocker.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

View this pull request in Lando to land it once approved.

@emilio
emilio requested a review from a team September 4, 2026 11:39
@emilio
emilio force-pushed the highlight-restrictions branch from 320509d to b3db60c Compare September 4, 2026 11:58

@dshin-moz dshin-moz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think webkit text properties are allowed, are they?
Otherwise the change looks good - seems to be mostly refactoring Option<PropertyFlags> to be just PropertyFlags, since that's a bitfield and can be empty

Comment thread servo/components/style/properties/data.py Outdated
Comment thread servo/components/style/properties/data.py
…ascade time. r=#style

Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.
@emilio
emilio force-pushed the highlight-restrictions branch from b3db60c to 144eedf Compare September 4, 2026 13:25
@lando-worker

lando-worker Bot commented Sep 4, 2026

Copy link
Copy Markdown

Pull request closed by commit b9c51f5

lando-worker Bot pushed a commit that referenced this pull request Sep 4, 2026
…ascade time. r=dshin

Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.

Pull request: #357
@lando-worker lando-worker Bot closed this Sep 4, 2026
github-actions Bot pushed a commit to DioxusLabs/stylo that referenced this pull request Sep 5, 2026
…ascade time. r=dshin

Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.

Pull request: mozilla-firefox/firefox#357
lando-worker Bot pushed a commit that referenced this pull request Sep 6, 2026
…ascade time. a=dmeehan

Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.

Pull request: #357

Differential Revision: https://phabricator.services.mozilla.com/D323847
lando-worker Bot pushed a commit that referenced this pull request Sep 6, 2026
…ascade time. a=dmeehan

Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.

Pull request: #357

Differential Revision: https://phabricator.services.mozilla.com/D323848
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 7, 2026
Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.

Pull request: mozilla-firefox/firefox#357

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2066814
gecko-commit: 9de51bc60b4affba54a5ad608a58ba06029fd64a
gecko-commit-git: b9c51f59c975365d9cd7799cb2f5d1027a4a8a64
gecko-reviewers: dshin
openresearchtools pushed a commit to openresearchtools/BashKitten that referenced this pull request Sep 22, 2026
…ascade time. a=dmeehan

Matches Chrome and the spec in terms of em / lh units etc, and prevents
border-radius to set the border-background flag without extra tracking.

Pull request: mozilla-firefox/firefox#357

Differential Revision: https://phabricator.services.mozilla.com/D323848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants