fix(ci): make the endpoint-coverage check offline and deterministic - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR was drafted by Claude via back-and-forth with @njbrake. The reasoning and decisions are his; the prose is Claude's.
Makes the endpoint-coverage check deterministic. Companion to mozilla-ai/otari#516, which moves the drift gate into the gateway.
The check fetched
docs/public/openapi.jsonfrom otarimainover the network at test time, so its result depended on when it ran rather than on what the commit contained. An unchanged commit passed one day and failed the next. Because CI only runs on push and pull_request,mainhere was red from around July 21 and nobody saw it until August 6 (mozilla-ai/otari#438).The gate now runs in the gateway, comparing the manifest against the spec from the same commit, so drift fails in the repo that causes it. What is left here is offline and structural: sections non-empty, sections disjoint, entries well-formed.
sdk-endpoints.txtbecomes a generated artifact, pushed by the codegen workflow from the canonical copy in otari. AGENTS.md is updated accordingly, since it previously told agents to edit a file that will now be overwritten on the next regeneration.Net effect on what is caught: no loss. The spec comparison still happens, just somewhere it can be trusted. What is lost is a check that was never reliable here, because it could not see a spec change until someone happened to push.