Repository navigation
Moshpit sites: video files play in @profullstack/player - #594
Merged
Merged
Conversation
A video post that is a direct media file now upgrades to the house player (one control bar with auto-hide, fullscreen including iPhone) on a name's published site. The player is bundled by the server on first request into /pf-player.js + /pf-player.css (same origin, the pit.world pattern; the dist's bare hls.js/mpegts.js imports rule out serving it from node_modules). The <video controls> stays as the fallback. YouTube, Vimeo and PeerTube iframes are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ThreatCrush Security Scan0 finding(s) in the 9 file(s) this pull request changes. Nothing in the files this pull request changes. 114 pre-existing finding(s) elsewhere in the repository — **HIGH/CRITICAL**: 8 | **MEDIUM**: 87 | **LOW**: 19Not introduced by this pull request. The full set is in the Security tab.
…and 94 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
Regenerating pnpm-lock.yaml for the player also moved the 'latest' footer to 0.6.19, which fails ring-footer.test.mjs; footers are not part of this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a name's published site (
apps/pwa/src/lib/moshpit-site-page.mjs), a video post that is a direct media file now upgrades to@profullstack/player0.17.0 (one control bar with auto-hide, fullscreen including iPhone).apps/pwa/src/lib/player-bundle.mjs: Bun.build of the player into one same-origin ES module at/pf-player.js, plus/pf-player.css(the pit.world pattern; the player's dist imports hls.js/mpegts.js by bare name, so it cannot be served from node_modules as the other vendor files are).apps/pwa/public/pf-player-init.js: hands the existing<video>tocreatePlayerviamedia; native controls stay as the fallback./pf-player.js200 (containspux-player),/pf-player.css200.node --test818/818.🤖 Generated with Claude Code