Skip to content

chore: update pacer-lite/solid-hotkeys to latest (@fehmer) - #8538

Open
fehmer wants to merge 1 commit into
masterfrom
feature/update-tanstack-hotkeys
Open

fehmer wants to merge 1 commit into
masterfrom
feature/update-tanstack-hotkeys

Conversation

@fehmer

@fehmer fehmer commented Oct 28, 2026

Copy link
Copy Markdown
Member

Summary

@tanstack/pacer-lite             0.2.2 → 0.3.0   ESM-only build; lite-debouncer subpath + API unchanged
@tanstack/solid-hotkeys          0.10.0 → 0.17.0 sequences unified into createHotkey (0.14+), new scopes (0.15+)
@tanstack/solid-hotkeys-devtools 0.7.0 → 0.11.1  pins the devtools plugin to the same @tanstack/hotkeys core

3 source files, 5 lines — the only breaking changes we touch:

 src/ts/input/hotkeys/konami.ts
- createHotkeySequence(["ArrowUp", ...], cb)
+ createHotkey(["ArrowUp", ...], cb)              # 0.14: sequences are hotkeys; createHotkeySequence removed

 src/ts/components/pages/test/keymapLayouts.ts
- const options: FormatDisplayOptions = {};
+ const options: FormatDisplayOptions & { parts?: false } = {};  # 0.17: formatForDisplay overloads split on parts

 src/ts/components/common/Kbd.tsx
- {props.hotkey ? ...}
+ {props.hotkey !== undefined ? ...}              # 0.14: Hotkey = chord | sequence; truthiness flagged by oxlint

@tanstack/hotkeys (transitive) 0.8.0 → 0.18.0. The devtools package bump is required: the plugin reads registrations from the hotkeys core, so it must peer the same 0.18.0 version or the panel goes silent.

Evidence

  • Before: tsc --noEmit fails with 19 errors (createHotkeySequence no longer exported; formatForDisplay now returns string | string[] | string[][]); oxlint --type-aware fails on strict-boolean-expressions in Kbd
    After: tsc clean, oxlint clean, 1692/1692 tests pass
  • Browser (fresh load): all 4 hotkeys registered in the new devtools panel (global scope; konami shown as seq); konami opens keymash; real Tab opens commandline, Escape closes it, then quick-restarts (words change); keymap legend renders ⌃⇧⌥⌘⌫↵; footer kbds render escape / shift + cmd + p; no console errors

Merge Danger

Door: two-way — reverting the version pins and the 5-line code diff restores 0.10.0/0.2.2

Blast Radius: keyboard — hotkey system (quick restart, commandline, konami), devtools panel, and LiteDebouncer (version-history modal, solid-db flush strategy); runtime behaviour of our wrappers is unchanged

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Oct 28, 2026
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​tanstack/​solid-hotkeys-devtools@​0.7.0 ⏵ 0.11.174 +41009998100
Updated@​tanstack/​solid-hotkeys@​0.10.0 ⏵ 0.17.084 +710010098 -1100
Added@​tanstack/​pacer-lite@​0.3.010010010091100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants