You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I'm new to this codebase and have been reading through some open PRs to learn, this one caught my attention. Please correct me if I'm misreading anything.
On the test in optional_require.test.ts - the new test covers the case where the addon is absent and built-in is used instead. But since CI explicitly installs @mongodb-js/zstd via run-tests.sh, this test would always skip there. The priority behaviour i.e. built-in preferred over addon when both are present, doesn't seem to have test coverage. Is that intentional?
On the compression test in compression.test.ts - I'm new to zstd so correct me if I'm wrong. Reading through the code, it looks like on Node 22.15.0+ both compress() and decompress() end up using the same built-in implementation. Doesn't that make the round-trip test self-referential? I see zstd frames always start with magic bytes 0xFD2FB528 per the spec, would checking those bytes be a simpler independent verification?
Happy to be corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
@mongodb-js/zstdwhen built-in support is unavailableRelease Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript