fix(router): diff file/manifest watcher reloads to reuse unchanged graph muxes#17
Open
arutkowski00 wants to merge 1 commit into
Open
fix(router): diff file/manifest watcher reloads to reuse unchanged graph muxes#17arutkowski00 wants to merge 1 commit into
arutkowski00 wants to merge 1 commit into
Conversation
…aph muxes Populate routerconfig.Response Changes/Hashes on watcher hot-reloads so graph_server can reuse feature-flag muxes instead of rebuilding all ~60 graphs on every reload when only one variant changed.
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routerconfig.Response.ChangesandHashes, matching the CDN split-config poller behaviorgraph_servercan reuse unchanged base/FF muxes instead of rebuilding all graphs on every watcher eventmondaytweaks.IncrementalWatcherReload(defaults totrue)Root cause
Watcher callbacks passed
routerconfig.Response{Config: cfg}withChanges/Hashesnil, forcingneedNewBaseGraphMux = trueand skipping FF-mux reuse. Every reload rebuilt the base mux and all ~60 feature-flag muxes even when only one variant changed, leaving large freed-but-unreturned RSS spikes.Test plan
go test ./pkg/routerconfig/... -run 'TestDiffGraphHashes|TestGraphHashesChanged|TestComputeGraphHashesFromConfig'go test ./router-tests/protocol/... -run 'TestConfigHotReload'buildGraphMuxcount ≈ 1 (not ~60)