Skip to content

fix(runtime): name the group pin a node timeout pin falls back to (#675) - #1273

Open
aviggiano wants to merge 1 commit into
unstablefrom
fix/675-timeout-warning-polish
Open

aviggiano wants to merge 1 commit into
unstablefrom
fix/675-timeout-warning-polish

Conversation

@aviggiano

@aviggiano aviggiano commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #1256 (issue #675).

Problem

Change

  • timeout-shadowing.ts: for a node pin whose group also pins, the message now ends with "Raise the pin, or remove it to fall back to groups.<g>.defaults.timeout_seconds=." Other pins keep the old text. The comparison and the set of reported pins do not change.
  • The doc comment in timeout-shadowing.ts and the CHANGELOG now keep only the resolution-order claim.
  • docs/reference/configuration.md and the CHANGELOG now say validate, doctor and run.

Tests

  • New: a run default equal to the packaged 7200 s pins reports no warning.
  • New: a node fanned out to claude (5400), deepseek (10800) and default (run default 3600) with a 1800 pin is reported once, against model profile deepseek (10800).
  • Extended: the plan test has a node pinned at 3000 inside a group pinned at 7200. Its warning names the group fallback. The other warnings keep the old remediation text.
  • To check that the tests catch bugs, I ran them against broken versions of the source:
  • Ran: runtime tests matching timeout|doctor and ^validate|^plan , eslint and prettier on changed files, pnpm --filter @ultrafuzz/runtime typecheck, ESLINT_PLUGIN_DIFF_COMMIT=origin/unstable pnpm -w lint:strict:ci, pnpm -w docs:check.

🤖 Generated with Claude Code

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were identified.

Summary

The PR corrects the timeout-warning remediation for node pins inside pinned groups, updates the documented commands and root-cause wording, and adds equality and model fan-out tests.

Reviews (1) · Last reviewed commit: "fix(runtime): name the group pin a node ..."

Follow-up to #1256.

- A node pin inside a group that also pins falls back to the group pin
  when removed, not to the profile or run default. The warning now says
  so and names the group pin, instead of "remove the pin to use the
  longer default".
- validate, doctor and run report the warning; there is no plan command.
  Fix the docs and CHANGELOG.
- The 7200 s pins did not cause the goal node timeouts in #675 (the
  oversized goal statement did, #680/#690). Keep only the resolution
  order claim in the CHANGELOG and the doc comment.
- Test that a pin equal to the default stays silent, and that a node
  fanned out to several profiles is reported against the longest one.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@aviggiano
aviggiano requested a review from a team as a code owner October 2, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant