Skip to content

Header - onHeadPress#253

Open
aravi1626 wants to merge 5 commits intomohitk05:masterfrom
aravi1626:prev-next
Open

Header - onHeadPress#253
aravi1626 wants to merge 5 commits intomohitk05:masterfrom
aravi1626:prev-next

Conversation

@aravi1626
Copy link
Copy Markdown

@aravi1626 aravi1626 commented Jan 31, 2023

  • make header pressable
  • include next and previous icon for navigation

@aravi1626
* chore:
47f16fe 
- assets: next and prev svg
- components: container modification
- util: renderIf
@aravi1626
* chore:
b85b900 
- navigate next story: functionality
- navigate prev story: functionality
@aravi1626
* chore:
aae1dbe 
- header: clickable header tab
@aravi1626
* chore:
ee22d01 
+ Header props: onHeadPress
+ withHeader: onClick attribute added to div
- Header: removed onHeadPress
* modified next & prev zIndex
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-insta-stories ❌ Failed (Inspect) Feb 1, 2023 at 4:44AM (UTC)

@aravi1626
* production build
56dfcbc 
- dist folder removed from .gitignore
@danielboros1990
Copy link
Copy Markdown

danielboros1990 commented Feb 13, 2023 •
edited
Loading

@mohitk05 can you pls merge this update? will be very useful. @aravi1626 thx for this modification.

mohitk05
mohitk05 reviewed Feb 13, 2023
View reviewed changes
Comment thread dist/components/Container.d.ts
@@ -0,0 +1,2 @@
/// <reference types="react" />
Copy link
Copy Markdown
Owner

@mohitk05 mohitk05 Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uncommit the generated declaration files? They are meant to be generated only in the output directory.

Copy link
Copy Markdown

@danielboros1990 danielboros1990 Feb 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aravi1626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohitk05 mohitk05 mohitk05 left review comments

+1 more reviewer

@danielboros1990 danielboros1990 danielboros1990 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aravi1626 @danielboros1990 @mohitk05