Repository navigation
Feat/socketio redis adapter - #12
Merged
Merged
Conversation
Needed so Socket.io room-based broadcasts (notifications, submissions) work correctly across multiple Strapi instances instead of only the instance that received the event.
Both submission-socket and notification-socket broadcast via `io.to(room).emit(...)`. Socket.io's default in-memory adapter keeps room membership local to each process, so with more than one Strapi instance behind a load balancer, a client connected to instance B never receives events emitted from instance A even if it joined the same room. This silently drops real-time notifications/submission updates for a subset of users instead of throwing an error. - Adds Redis pub/sub adapter, gated on REDIS_URL - Logs a loud warning (not a silent fallback) when REDIS_URL is missing, since that failure mode is otherwise very hard to notice until you scale past one instance - No behavior change for the current single-instance deployment See AxeCode_QA_Scalability_Plan.md section 4.2 for the full analysis.
Separate from judge0-redis (different lifecycle/blast-radius): this one backs real-time notifications and submission-update broadcasts and is required before scaling the strapi service to >1 replica.
✅ Pipeline Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.