Skip to content

fix: speed up issue detail queries #7900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Oct 13, 2026
Merged

fix: speed up issue detail queries #7900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions ...abrinth/.sqlx/query-6f1e755a90bdc960e164785b16e1794cfb4dd6f8bf54985c182840dfeffd05f8.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 0 additions & 34 deletions ...abrinth/.sqlx/query-9f8d7940181e60f6867f77f6e84e04d15b222762a4b5f2102b404e06f5285f4a.json
View file
Open in desktop

This file was deleted.

63 changes: 35 additions & 28 deletions apps/labrinth/src/routes/internal/delphi/tech_review_queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,37 +145,44 @@ pub async fn sync_projects(

let rows = sqlx::query!(
r#"
WITH current_details AS (
SELECT
detail.project_id,
detail.status,
detail.severity
FROM delphi_issue_details_with_statuses detail
INNER JOIN delphi_report_issues issue ON issue.id = detail.issue_id
INNER JOIN delphi_reports report
ON report.id = issue.report_id
AND NOT EXISTS (
SELECT 1
FROM delphi_reports newer_report
WHERE
newer_report.file_id = report.file_id
AND newer_report.delphi_version > report.delphi_version
)
)
SELECT
requested.project_id AS "project_id!: DBProjectId",
BOOL_OR(current_details.project_id IS NOT NULL) AS "has_details!",
COALESCE(
BOOL_OR(
current_details.status IN ('pending', 'unsafe')
AND current_details.severity != 'hidden'
),
FALSE
) AS "needs_review!"
EXISTS (
SELECT 1
FROM versions version
INNER JOIN files file ON file.version_id = version.id
INNER JOIN delphi_reports report ON report.file_id = file.id
INNER JOIN delphi_report_issues issue ON issue.report_id = report.id
INNER JOIN delphi_report_issue_details detail ON detail.issue_id = issue.id
WHERE version.mod_id = requested.project_id
AND NOT EXISTS (
SELECT 1
FROM delphi_reports newer_report
WHERE newer_report.file_id = report.file_id
AND newer_report.delphi_version > report.delphi_version
)
) AS "has_details!",
CASE WHEN EXISTS (
SELECT 1
FROM delphi_tech_review_queue queued
WHERE queued.project_id = requested.project_id
) THEN FALSE
ELSE EXISTS (
SELECT 1
FROM delphi_issue_details_with_statuses detail
INNER JOIN delphi_report_issues issue ON issue.id = detail.issue_id
INNER JOIN delphi_reports report ON report.id = issue.report_id
WHERE detail.project_id = requested.project_id
AND detail.status IN ('pending', 'unsafe')
AND detail.severity != 'hidden'
AND NOT EXISTS (
SELECT 1
FROM delphi_reports newer_report
WHERE newer_report.file_id = report.file_id
AND newer_report.delphi_version > report.delphi_version
)
) END AS "needs_review!"
FROM unnest($1::bigint[]) AS requested(project_id)
LEFT JOIN current_details
ON current_details.project_id = requested.project_id
GROUP BY requested.project_id
"#,
&project_ids.iter().map(|id| id.0).collect::<Vec<_>>(),
)
Expand Down
Loading