Is that-depends possible to support inject almost everywhere without wiring? #39

Activity

1. lesnik512

   added

   questionFurther information is requestedFurther information is requested

   on Jun 21, 2024
2. lesnik512 commented on Jun 21, 2024

   

   lesnik512

   on Jun 21, 2024

   Last edited by lesnik512

   Member

   More actions

   Hello, @rumbarum

   1. In case of that-depends there is no wiring, so such thing won't work and I'm not sure that it's needed:

   service: Service = Provide[Container.service]

   You can just build dependency anywhere in you code like this

   2. About circular import error: I personally think that circular import error should be resolved by refactoring code instead of hiding it by wiring of DI.
3. rumbarum commented on Jun 21, 2024

   

   rumbarum

   on Jun 21, 2024

   Author

   More actions

   @lesnik512
   Thank you for your answer.

   This is my use case of inject something directly. I could wrap it by something callable and inject it as args. But this is much simpler. So I applied this pattern when necessary.

   session: async_scoped_session = Provide["session"]
   
   class SQLAlchemyMiddleware:
       def __init__(self, app: ASGIApp) -> None:
           self.app = app
   
       async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
           session_id = str(uuid4())
           context = set_session_context(session_id=session_id)
           try:
               await self.app(scope, receive, send)
           except Exception as e:
               raise e
           finally:
               await session.remove()
               reset_session_context(context=context)

   Anyway, I will try review your package.

   👍React with 👍1Reacted by Artur Shiriev
4. modern-python

   locked and limited conversation to collaborators on Jun 21, 2024
5. lesnik512

   converted this issue into a discussion #40 on Jun 21, 2024