Repository navigation
fix: drop ty ignore that ty 0.0.88 reports as unused - #679
Merged
Merged
Conversation
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 4b8f55e | Previous: f2e0937 | Ratio |
|---|---|---|---|
benchmarks/test_guard_by_type.py::test_g16_resolve_by_type |
6854398.1211317815 iter/sec (stddev: 9.478962043590499e-9) |
6788673.153145498 iter/sec (stddev: 1.190085855165319e-8) |
0.99 |
benchmarks/test_guard_by_type.py::test_g17_resolve_by_type_large_registry |
6831358.421804881 iter/sec (stddev: 5.758226156834196e-9) |
6675942.666497597 iter/sec (stddev: 1.2181516920447562e-8) |
0.98 |
benchmarks/test_guard_cold.py::test_g8_cold_first_resolve |
45084.857206811204 iter/sec (stddev: 0.00002825164531692087) |
32460.707337287717 iter/sec (stddev: 0.000030105154702014322) |
0.72 |
benchmarks/test_guard_cold.py::test_g8b_cold_first_resolve_cached |
35347.12209868811 iter/sec (stddev: 0.00012752307231689427) |
25838.500141462082 iter/sec (stddev: 0.00010132802659525374) |
0.73 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[1] |
895.6933994511431 iter/sec (stddev: 0.000018635042223074477) |
886.4468956495458 iter/sec (stddev: 0.00006941678537555128) |
0.99 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[2] |
868.2503298025697 iter/sec (stddev: 0.00003218314061593594) |
805.0854602274844 iter/sec (stddev: 0.0001178027996523742) |
0.93 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[4] |
831.7839303221097 iter/sec (stddev: 0.00008741181086193255) |
717.7343373058015 iter/sec (stddev: 0.00010904232994602348) |
0.86 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[1] |
24750.63222381411 iter/sec (stddev: 0.000005245751013172937) |
10468.318549963036 iter/sec (stddev: 0.000010217419970589726) |
0.42 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[2] |
13147.312015487198 iter/sec (stddev: 0.000010255943621023493) |
8243.550761112238 iter/sec (stddev: 0.00000978829769011275) |
0.63 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[4] |
6189.034783956631 iter/sec (stddev: 0.000024873531894700136) |
2922.9271605301215 iter/sec (stddev: 0.0000622720134779716) |
0.47 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[1] |
17455.649920679272 iter/sec (stddev: 0.00000790780376446149) |
9014.905244332986 iter/sec (stddev: 0.000009928395288672719) |
0.52 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[2] |
7496.491641918416 iter/sec (stddev: 0.000011653624704342673) |
5003.419837466154 iter/sec (stddev: 0.000014895077282992753) |
0.67 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[4] |
3608.6586516593097 iter/sec (stddev: 0.000026639106735495544) |
1952.162740093355 iter/sec (stddev: 0.0000707940115661263) |
0.54 |
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[1] |
56756.80278148087 iter/sec (stddev: 0.000002003497353210248) |
18170.46164345985 iter/sec (stddev: 0.000003461503175554291) |
0.32 |
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[2] |
31178.589662164763 iter/sec (stddev: 0.000007392483902693923) |
12501.87397883129 iter/sec (stddev: 0.000016678354575944098) |
0.40 |
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[4] |
10615.673688372823 iter/sec (stddev: 0.000017171385765766328) |
5644.622737186599 iter/sec (stddev: 0.000046511807561660205) |
0.53 |
benchmarks/test_guard_lifecycle.py::test_g6_build_child_container |
3052220.7500544456 iter/sec (stddev: 1.9201760149122597e-8) |
2612485.6305185594 iter/sec (stddev: 2.0068701134218918e-8) |
0.86 |
benchmarks/test_guard_lifecycle.py::test_g6b_build_child_container_auto_scope |
3508371.236821635 iter/sec (stddev: 1.2371904454385705e-8) |
2901598.4543062635 iter/sec (stddev: 1.9878341562554616e-8) |
0.83 |
benchmarks/test_guard_lifecycle.py::test_g7_request_lifecycle_batch |
6103.800914255 iter/sec (stddev: 0.0000057604503388652715) |
4561.0523366386515 iter/sec (stddev: 0.000006249721370033468) |
0.75 |
benchmarks/test_guard_lifecycle.py::test_g7c_event_loop_floor_control |
111745.82885368228 iter/sec (stddev: 9.072732501426707e-7) |
92400.7921227213 iter/sec (stddev: 9.397260708931958e-7) |
0.83 |
benchmarks/test_guard_lifecycle.py::test_g7b_request_cycle_sync |
737170.5690686726 iter/sec (stddev: 5.032517788649672e-8) |
582141.1494951276 iter/sec (stddev: 6.491243377174972e-8) |
0.79 |
benchmarks/test_guard_lifecycle.py::test_g13_teardown_at_scale |
109068.1121277307 iter/sec (stddev: 8.151491333435432e-7) |
90370.69244293589 iter/sec (stddev: 0.0000010458008302387503) |
0.83 |
benchmarks/test_guard_lifecycle.py::test_g13b_teardown_at_scale_async_no_finalizers |
921.3355768766771 iter/sec (stddev: 0.0019271199236121058) |
819.6178236379287 iter/sec (stddev: 0.0009805423202325814) |
0.89 |
benchmarks/test_guard_resolve.py::test_g1_transient_resolve |
4076106.201777354 iter/sec (stddev: 1.735846825321731e-8) |
3633264.7917751158 iter/sec (stddev: 2.0594789326592733e-8) |
0.89 |
benchmarks/test_guard_resolve.py::test_g2_cached_resolve |
6584364.741122377 iter/sec (stddev: 1.5529059419283127e-8) |
6683075.845603237 iter/sec (stddev: 1.2783496503449223e-8) |
1.01 |
benchmarks/test_guard_resolve.py::test_g3_deep_chain |
1402716.2618482606 iter/sec (stddev: 4.127572693310589e-8) |
1269370.675849653 iter/sec (stddev: 4.35737533118308e-8) |
0.90 |
benchmarks/test_guard_resolve.py::test_g4_wide_resolve |
838442.803777312 iter/sec (stddev: 3.4971080160878404e-7) |
744610.4259701986 iter/sec (stddev: 2.952060239471592e-7) |
0.89 |
benchmarks/test_guard_resolve.py::test_g5_cross_scope |
3594001.7906501708 iter/sec (stddev: 1.4988351757751136e-8) |
3278090.6761135682 iter/sec (stddev: 1.941714619024936e-8) |
0.91 |
benchmarks/test_guard_resolve.py::test_g9_context_resolve |
2719146.1881062007 iter/sec (stddev: 1.386433934961487e-7) |
2435998.256555671 iter/sec (stddev: 1.1223347442487627e-7) |
0.90 |
benchmarks/test_guard_resolve.py::test_g12_override_active_resolve |
1430444.902695495 iter/sec (stddev: 1.745528454404275e-8) |
1323090.0582936974 iter/sec (stddev: 3.958171930245851e-8) |
0.92 |
benchmarks/test_guard_resolve.py::test_g18_alias_hop |
6657819.312438109 iter/sec (stddev: 3.9596453703457014e-9) |
6624859.826278795 iter/sec (stddev: 1.2871663895490036e-8) |
1.00 |
benchmarks/test_guard_validate.py::test_g10_validate_deep_chain |
72907.83317236435 iter/sec (stddev: 0.000011853098755439171) |
53258.92800756829 iter/sec (stddev: 0.000012691844949725638) |
0.73 |
benchmarks/test_guard_validate.py::test_g11_validate_wide |
41446.128936562964 iter/sec (stddev: 0.000016890540895074145) |
31127.074319954147 iter/sec (stddev: 0.000019604893366383424) |
0.75 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #678.
ty 0.0.88 no longer reports
invalid-mutable-overrideon the__module__assignment intest_compile_resolver_rejects_an_unknown_provider_type. #677 added an ignore for that 0.0.87 regression, and 0.0.88 now flags it asunused-ignore-comment. This drops the ignore and puts the comment back on the same line.I ran ty 0.0.88 on main of every org repo that uses ty. modern-di was the only one that failed.
Locally with ty 0.0.88,
ty check,ruff format --check,ruff checkandeof-fixer --checkare clean, andtests/test_resolver_compiler.pypasses.