Repository navigation
feat: add manage_lifespan flag to setup_di - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
setup_di(broker, container)gains a keyword-onlymanage_lifespan: bool = True, matching modern-di-fastmcp's flag of the same name.With the default, nothing changes:
WORKER_STARTUPopens the root container andWORKER_SHUTDOWNcloses it. Withmanage_lifespan=False,setup_diskips registering those two handlers. It still attaches the container tobroker.stateand registerstaskiq_message_provider, and each task still builds and closes its own child container. The caller owns the root, for example withasync with container:around the apps that share it.Skipping the handler registration leaves the default path unchanged, and the flag adds no work per worker cycle.
Docs:
Tests in
tests/test_lifespan.py, all withmanage_lifespan=False:async with, the APP finalizer runs once, at the caller's exitWith the flag accepted but ignored, the three tests fail on their assertions. The existing lifespan tests cover the default and are unchanged.