Repository navigation
feat: add manage_lifespan to setup_di - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77
setup_di(app, container)gets a keyword-onlymanage_lifespan: bool = True, matching modern-di-fastmcp. With the default nothing changes. Withmanage_lifespan=Falsethe app never opens or closes the root container, so the user can own it, for example withasync with container:around running the app. Providers are still registered and the middleware still builds and closes a request container per message.The
container.openhook now registers afterinstall_middlewareinstead of before it. Both run on startup before the broker consumes, so the order only shows ifinstall_middlewareraises for a missing broker.README: the flag is in the API table, plus a short "Sharing a container" section. CONTEXT.md: the root container entry now says its app-tracked lifetime is the default.
Tests in
tests/test_lifespan.py, written first and failing before the change:async with, the APP finalizer runs once, at the user's exitThe existing restart test covers the default.