Repository navigation
docs: say which shutdown hooks run after the root container closes - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Shutdown order" subsection to the README, at the end of Usage.
setup_dicloses the root container from a provider lifespan it adds to the server, and FastMCP has no public hook that runs after the server lifespan, so this is a docs fix. The section says that the teardown ofFastMCP(lifespan=...)and of providers added beforesetup_diruns after the close. It showsmanage_lifespan=Falsewithasync with container:in the user's own server lifespan.I ran the repro from the issue (fastmcp 4.1.0, modern-di 4.1.0). The output matches the issue: the server lifespan teardown and a provider added before
setup_digetContainerClosedError, and a provider added aftersetup_diresolves fine. With the documented pattern, both failing cases resolve a live container. The new code block also runs together with the Usage example, and tools still resolve throughFromDI.Closes #3