Repository navigation
docs: share a container with an app of another integration - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Sharing a container" section said "another app", which can read as a second aiohttp app. Two aiohttp apps cannot share one container yet: on modern-di 4.1.0 the second
setup_diraisesDuplicateProviderTypeErroruntil a release includes modern-python/modern-di#681.The example is now an app of another integration (a FastStream consumer). The section also says to pass
manage_lifespan=Falseto everysetup_dithat shares the container, as the modern-di docs do, and links the shared-container recipe.