Repository navigation
fix: keep the parent's child container when a sub-app also calls setup_di - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
When the parent app and a sub-app both call
setup_di, both middlewares store the child container under the same request key. On a sub-app route the inner middleware deleted the key on exit, and the outer middleware's unconditionaldelthen raisedKeyError, so the response became a 500.The middleware now reads the key's previous value before setting its own. On exit it puts that value back, or deletes the key when there was none. Deleting in the outermost middleware still breaks the request/container reference cycle, so the existing no-cyclic-garbage test is unchanged. A sub-app route resolves from the innermost app's container, and each middleware still closes the child container it opened.
Tests in
tests/test_subapps.py:setup_dion both apps,/xreturns the parent's value and/sub/xreturns the sub-app's, both 200.setup_dion the parent only,/sub/xresolves from the parent's container. This one already passed before the fix and guards against a regression.The first and third tests fail on
mainwith theKeyError.The README now says which container a sub-app route resolves from in each setup.