Repository navigation
fix: annotate TimersBroker._subscribers as WeakSet for ty 0.0.87 - #107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106.
The scheduled dependency check picked up ty 0.0.87, which turns on
invalid-mutable-overrideby default and now checks overrides of attributes declared in__init__. It reports five errors on main.TimersBrokerannotated_subscribersand_publishersaslist, but faststream'sRegistratorsets both to aWeakSet._subscribersis now annotated asWeakSet[TimersSubscriber], the same as faststream-outbox, with an ignore becauseWeakSetis invariant. Nothing reads_publishers, so its annotation is gone, along with the import it used._outer_config: TimersBrokerConfignarrows faststream'sBrokerConfigin three places. faststream's bases aren't generic over the config, so each line gets a per-line ignore.Locally with ty 0.0.87,
just lint-ciis clean andjust test-cipasses (168 passed, 100% coverage).