Repository navigation
fix: ty 0.0.86 invalid-property-type-override on subscribers - #105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104.
ty 0.0.86 added
invalid-property-type-override.TimersBroker.subscribersnarrows the inheritedlist[SubscriberUsecase[TimerMessage]]tolist[TimersSubscriber], which ty rejects becauselistis invariant.The narrowing is sound in practice: the base property builds a new list on each call, and every subscriber this broker registers is a
TimersSubscriber. Removing the override would move casts intotesting.py(two sites) andtests/test_unit.py, so this adds a targetedty: ignorein line with the other ignores in the package.Locally,
just lint-ciis clean and the full suite passes against Redis 8 (168 passed).