Repository navigation
fix: link the 0.15 upgrade guide from the pending-index drift error - #231
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #229 for 0.15.0, no issue.
Every table migrated before 0.15 fails
validate_schema()until_pending_idxis rebuilt. The error was accurate but gave no hint about what to do:When the missing index is
_pending_idx, the line now ends with a link to the "Upgrading to 0.15" section of the Alembic guide:The base URL is the one
_AUTOGEN_BLIND_HINTalready uses, and I checked that the built docs render theupgrading-to-015anchor. A table that's missing the index entirely gets the same pointer, which still helps: that section shows the index's exact shape.Test: the existing
test_validate_schema_reports_the_pre_0_15_pending_index_shapenow also requires the link, and it failed before the change.Verification: 692 tests pass in docker at 100% coverage,
ruffis clean,tyshows the same 6 diagnostics asmain, and the docs build.