Repository navigation
ci: test on PostgreSQL 13 and document it as the minimum - #228
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #216. For 0.15.0: the documented minimum moves from PostgreSQL 12 to 13, and CI now tests on 13.
Why
outbox_autovacuum_ddlalways setsautovacuum_vacuum_insert_scale_factorandautovacuum_vacuum_insert_threshold, and both arrived in PostgreSQL 13. On 12 theALTER TABLEfails with "unrecognized parameter", andvalidate_schema(check_autovacuum=True)can never pass. The docs said 12+, and CI only ran 17, so nothing caught this. PostgreSQL 12 has been end of life since November 2024.I ran the full suite locally against both versions, swapping only the Postgres image:
test_validate_schema_autovacuum_ok_*testsNo other test depends on 13, so nothing besides the autovacuum options needs it.
Changes
floorsjob now runs onpostgres:13instead of 17. That job already installs the lowest declared dependency versions, so it now tests the lowest supported server too, and thepytestmatrix stays on 17 with the newest dependencies. No new job.floorsskips the weekly scheduled run, so 13 is covered on every pull request and every push tomain.installation.mdnow says PostgreSQL 13+ and why.alembic.mdsays the insert-triggered pair needs 13 or later.Release note (0.15.0)