Repository navigation
fix: narrow LogRecord.exc_info by truthiness for ty 0.0.89 - #105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled dep-check lint job failed on ty 0.0.89 (run 38892705113):
ty 0.0.89 ships a newer typeshed where
LogRecord.exc_infoalso includesLiteral[False]. On 0.0.88 it wastuple[...] | tuple[None, None, None] | None. Theis not Nonecheck no longer rules outFalse, so the subscript on the next line fails.assert exc_inforemoves bothNoneandFalse. At runtime the value is a 3-tuple and always truthy, so the test checks the same thing as before.Checked locally with ty 0.0.89:
just lint-cipasses, and the unit tests pass (218). I didn't run the integration tests because there's no Kafka broker on this machine; CI covers them.