Repository navigation
docs: merge the upsert ADRs, drop replaced and non-ADR records, renumber - #62
Merged
Merged
Conversation
ADRs that a later decision replaces are now deleted once their reasoning moves into the new record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tidies up
docs/adr/and changes the rule for replaced records.Rule change
docs/adr/README.mdused to keep a replaced ADR in place withsuperseded_byfrontmatter. Now the reasoning that still holds moves into the new record and the old file is deleted, since git history keeps it. With that, every file in the directory is a current decision, so ADRs carry no frontmatter.Records
xmaxcheck, same rejected options. This also removes the duplicate 0012.IS DISTINCT FROMand monotonic details now live inINVARIANT:docstrings ontest_system_messages_count_as_unreadandtest_marking_read_is_monotonic. The reasonGREATESTruns inside the UPDATE was already inChatMembersRepository.mark_read's docstring.Nothing outside
docs/adr/cites an ADR by number.docs/agents/domain.mdcites ADR-0001, which keeps its number.Verification
Run locally:
just adr-check,ruff,ty, and the full suite (141 passed, 100% coverage).