Repository navigation
docs: ADR 0012 matches db-retry 0.8.1, require db-retry>=0.8.1 - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires db-retry 0.8.1 and brings ADR 0012 in line with it.
db-retry 0.8.1 (modern-python/db-retry#75) rolls back a dead session transaction when
Transactionis entered. ADR 0012 said that any query outside the block leaves a dead transaction the retry cannot roll back. That is no longer true for a query after the block: the next attempt entersTransactionfirst and recovers. A query before the block still runs first on the retried attempt and fails it. So the rule stays, and the ADR now gives the narrower reason.docs/adr/0012-pool-pre-ping-off.md: reworded the rule sentence. The record is 144 words.pyproject.toml,uv.lock:db-retry>=0.8.1, locked at 0.8.1.just test: 141 passed, 100% coverage, with db-retry 0.8.1 in the container.