Leave full URLs in VIDEO_FILE untouched - #162
Merged
Merged
Conversation
Contributor
|
Good catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Leave
VIDEO_FILEuntouched in the generated HTML when it's a full URL, and only add the leading/to filenames and paths.Why
#160 fixed the video 404ing on multi-segment paths by always emitting
/${VIDEO_FILE#/}. That's right for filenames, but it also prefixes URLs, soVIDEO_FILE=https://example.com/v.mp4becamesrc="/https://example.com/v.mp4". That worked before #160.Change
scripts/index/80-index.sh: skip the prefix when the value contains://..github/workflows/test.yml: new container run withVIDEO_FILE=https://example.com/v.mp4, asserting thesrcis left as-is. Nothing covered URLs before.README.md:VIDEO_FILErow now says a full URL is accepted and used as-is.Tested
Built the image and checked the
srcon/some/random/path:VIDEO_FILEsrc/video.mp4custom.mp4/custom.mp4/video.mp4/video.mp4https://example.com/v.mp4https://example.com/v.mp4The URL container also starts and passes the healthcheck.