Repository navigation
Follow system light and dark appearance - #10
Open
victorarias wants to merge 2 commits into
Open
victorarias wants to merge 2 commits into
victorarias wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ooooops!
I asked my agent to add dark mode support, and I didn't realize it took the liberty to make a PR upstream! I wanted a PR on my fork to review. Feel free to close. Sorry!!
I reviewed the code now and it seems straightforward enough, so I'm leaving the PR open. Thanks for building this, it's super useful.
What changed
Glance now follows the system's light or dark appearance, including changes while the editor is open. A shared UI palette covers the toolbar, inspectors, dropdowns, pickers, numeric inputs, tooltips and preview preparation state. Screenshot content, annotation colors, backdrops and exports keep their colors.
Uses GPUI's window appearance and change observer. There’s no theme preference to configure or new command to expose through MCP.
Validation
cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings, andcargo test --lockedpass (159 tests passed; 18 opt-in tests ignored).Unreleasedin CHANGELOG.md.On macOS 26.7.1, verified native Aqua → Dark Aqua → Aqua changes while the tools, open picker, backdrop dropdown, animation and image-tools panels remained open. Each change checked the palette and unchanged document pixels. The images above come from the native Metal renderer with the built-in practice canvas. Regression coverage also checks selected annotations, preview revision, undo/redo, backdrop rendering and label contrast.
The system-wide preference was left unchanged; native window/application appearance exercised the notification path. Linux desktop appearance and native OS dialogs were not manually verified.