Conversation
…e + model_kwargs PYTHONPATH injection"" This reverts commit 1112622.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
Security fix for GHSA-9g2v-fgfh-65rx (Snyk Security Labs report):
Fix 1 - validate_cmd in save_cmd (swift/ui/llm_train/utils.py):
Add shared validate_cmd() function that rejects control characters
(\x00-\x1f excluding \t \n \r) and ZIP signature bytes (PK\x03\x04,
PK\x01\x02, PK\x05\x06) in command strings. Applied to all three
save_cmd variants (SFT/RLHF/GRPO) to prevent ZIP archive embedding
in .sh files via --logging_dir parameter injection.
Fix 2 - blocklist for model_kwargs env vars (base_args.py):
Add _BLOCKED_MODEL_KWARGS blocklist of 19 known-dangerous environment
variables (PYTHONPATH, LD_PRELOAD, PYTHONSTARTUP, DYLD_INSERT_LIBRARIES,
BASH_ENV, etc.) that enable code execution, library injection, or
interpreter hijacking. _init_model_kwargs now skips blocked vars with
a warning log instead of blindly setting os.environ.