fix(loss): reuse aligned cross entropy under sequence parallelism - #10185
Open
Excelius-Wang wants to merge 1 commit into
Open
Excelius-Wang wants to merge 1 commit into
Excelius-Wang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit
--loss_type cross_entropyrecomputes ordinary causal cross entropy from labels that sequence parallelism has already shifted and sharded. This shifts the targets again and loses the gathered loss; with token weights, the gathered weights can also have a different length from the locally recomputed loss.Reuse the per-token loss already aligned, gathered and weighted by
Seq2SeqTrainer. When the callback infers the token count, preserve the default trainer's distributed normalization and training/evaluation scaling. The non-sequence-parallel path is unchanged.Validation:
OMP_NUM_THREADS=1 /tmp/ms-swift-core-test-venv/bin/python -m pytest tests/sequence_parallel/test_custom_cross_entropy.py tests/train/test_cross_entropy_loss.py -q: 5 passed, 8 subtests passed./tmp/ms-swift-lint-venv/bin/pre-commit run --all-files: all hooks passed.Coverage uses CPU Gloo with one or two data-parallel replicas. It does not exercise GPU distributed attention or a full SFT run. Related #10100 added token weighting for custom CE but did not validate sequence parallelism.