fix(sp): remove ring padding before unpacking model outputs - #10184
Open
Excelius-Wang wants to merge 1 commit into
Open
Excelius-Wang wants to merge 1 commit into
Excelius-Wang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequence-parallel output hook gathers Ring outputs with padding between packed samples, then
revert_padding_freesplits them using the original unpadded position IDs. Later samples can therefore include earlier padding and lose their own trailing tokens, changing pooled representations and downstream classification outputs.Remove Ring padding from each gathered output using the already-padded position-ID mask before downstream unpacking. Reuse the existing gather, padding layout, and autograd path; leave Ulysses-only behavior unchanged.
Validation:
pre-commit run --all-files: passed.A separate tiny Qwen3 CPU probe with natural dialogue lengths also matches reference hidden states, classification logits/loss, and local output gradients after the fix. Attention in that probe runs per full sequence; no full GPU Ring-attention training run was performed.