fix(metrics): align packed sequence accuracy with ring padding - #10182
Open
Excelius-Wang wants to merge 1 commit into
Open
Excelius-Wang wants to merge 1 commit into
Excelius-Wang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ring sequence parallelism gathers predictions and shifted labels in a per-sequence padded layout.
_compute_accstill groups them with the original unpaddedcu_seqlens, so sequence accuracy can attribute errors to the wrong sample or miss them entirely. For example, one correct and one incorrect packed sequence can be reported as 100% sequence accuracy.Derive the metric boundaries from the already-padded position IDs using
get_cu_seqlens_from_position_ids. This keeps the boundaries aligned with gathered tensors without changing communication, labels, or token accuracy.Validation:
pre-commit run --all-files: passed.No full GPU training run was performed; this fixes metric computation, not training loss.