fix(sp): exclude internal ring padding from MoE auxiliary loss - #10181
Open
Excelius-Wang wants to merge 1 commit into
Open
Excelius-Wang wants to merge 1 commit into
Excelius-Wang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ring sequence parallelism pads each packed sequence independently. The MoE output hook currently trims gathered router logits to the original total length, retaining internal padding and dropping valid tokens from later sequences. This changes the load-balancing loss and its gradients when router auxiliary loss is enabled.
Filter the gathered router logits using the padded position-ID mask in the ring path, reusing the existing padding layout. Keep the Ulysses-only trimming behavior.
Validation:
pre-commit run --all-files: passed.No full GPU distributed-attention training run was performed.