Repository navigation
Conversation
Two bots update dependencies here. Renovate handles crossplane-project.yaml, GitHub Actions and the Nix flakes, but none of the Go modules or uv.lock. Dependabot's security updates fill that gap by opening a PR for each Dependabot alert, which today means uv.lock and the Go module under compose-model-deployment's tests. This commit has Renovate fix those alerts too, so Dependabot's security updates can be turned off. Signed-off-by: Nic Cope <nicc@rk0n.org>
There was a problem hiding this comment.
This looks close to ready, with one question about whether routine updates need to run hourly along with vulnerability fixes. I checked the config against Renovate 44.221.4's source, and it does what its comments say. The commit "Run Renovate hourly so vulnerability fixes arrive promptly" could note the cost of hourly routine updates, which only the PR description records now.
Reviewed by modelplane-review 0f30f2d. Reply, or react 👍 or 👎, on each comment to help tune it.
Renovate now fixes vulnerability alerts in Dependabot's place, but it ran once a day, so an alert could wait up to a day for its fix PR. Dependabot opened one within minutes. This commit runs it hourly, with a concurrency group so a run that outlasts the hour can't overlap the next. Routine updates run hourly too, rather than on a daily schedule of their own, to keep the config simple. The cost is that an open nixpkgs-unstable digest PR is updated whenever the channel advances, and new PRs can open at up to two an hour rather than two a day. Lock file maintenance no longer needs its own schedule, since the hourly runs fall within its default of before 4am on Monday. Signed-off-by: Nic Cope <nicc@rk0n.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Renovate and Dependabot both open dependency PRs here. Renovate handles
crossplane-project.yaml, GitHub Actions and the Nix flakes. Dependabot's security updates open a PR for each Dependabot alert in the files Renovate skips, which today meansuv.lockand the Go module underfunctions/compose-model-deployment/tests/oracle. #674 is the latest.This PR has Renovate fix those alerts too, so we can turn Dependabot's security updates off. Renovate now runs its
gomodandpep621managers with routine updates and lock file maintenance disabled, so it only touches Go modules anduv.lockto fix an alert. It also runs hourly rather than daily, since Dependabot opens its fix PRs within minutes of an alert.I ran Renovate 44.221.4 against this repo with this config, in lookup-only dry-run mode. It planned fix branches for both open Go alerts (cel-go 0.26.0 to 0.29.0 and otel/trace 1.41.0 to 1.47.0, the same bumps as #674) and no other Go or Python updates. It also picked up the 36 dependencies that appear only in
uv.lock, so an alert for one of them can match. A lookup-only run doesn't update lock files, and no Python alert is open, so neither fix has run end to end.Running hourly also changes routine updates. An open
nixpkgs-unstabledigest PR gets updated each time the channel advances rather than at most once a day, and new PRs can open at two an hour rather than two a day, still capped at five open.To finish the switch after this merges, close #674 and run the Renovate workflow by hand. Once it opens the two Go fix PRs, turn off Dependabot security updates. Leave Dependabot alerts on, because Renovate reads them.
I have:
nix flake check(or./nix.sh flake check) and made sure it passes.Added or updated tests covering any composition function changes.git commit -s.