Repository navigation
Conversation
compose-serving-stack sets resource_to_telemetry_conversion on prometheus and prometheus_remote_write sinks, so their series keep the cluster, deployment, engine and role they belong to. Collector 0.161.0 deprecates that setting and warns about it at startup. Its replacement, resource_constant_labels, takes an allowlist. This sets it to the identity attributes, the only ones transform/identity leaves on the resource, so the exporters convert the same attributes as before. A sink that sets either setting itself gets no default, because an exporter refuses a config that sets both. Fixes modelplaneai#489. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: humoflife <markus.schweig@upbound.io>
|
Docs preview: https://modelplane-docs-pr-667.vercel.app (ready once the site's Content workflow finishes) |
Collaborator
|
/review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
compose-serving-stack sets
resource_to_telemetry_conversiononprometheusandprometheus_remote_writesinks so their series keep the cluster, deployment, engine and role they belong to. Collector 0.161.0 deprecates that setting and logs a warning for it at startup.This switches the default to its replacement,
resource_constant_labels, withincludedset to_IDENTITY.transform/identityleaves only those attributes on the resource, so the exporters convert the same attributes as before. A sink that sets either setting itself gets no default, because an exporter refuses a config with both (config.go).The issue asked for a real export to check against. I ran
otel/opentelemetry-collector-contrib:0.161.0with sinks rendered bycollector.exporters, exporting to a Prometheus 3.5.0 remote-write receiver and through theprometheusexporter, once with the old setting and once with the new default. Both produced the same labels on both exporters (cluster,deployment,engine,role,job,instance,service_name,service_instance_id); only the old one logged the deprecation warning. A config with both settings failed to start withcannot configure both resource_to_telemetry_conversion and resource_constant_labels.Fixes #489
I have:
nix flake check(or./nix.sh flake check) and made sure it passes.git commit -s.🤖 Generated with Claude Code