Repository navigation
Fix InferenceCluster InvalidNodePool and ClusterProviderConfig bugs - #604
Closed
RedbackThomson wants to merge 2 commits into
Closed
RedbackThomson wants to merge 2 commits into
RedbackThomson wants to merge 2 commits into
Conversation
Each compose_<cloud>_cluster builder checked that every node pool's class had a provisioning block for the cloud. On a miss it set ClusterReady=False with reason InvalidNodePool and returned, but compose_<cloud> carried on to derive_conditions, whose later ClusterReady=Provisioning replaced it. Only a Warning event said what was wrong. The early return also left the cloud cluster XR out of desired state, so Crossplane would try to delete a running cluster whose shared class lost its block. The check is now a gate beside check_devices_supported, before any cloud is composed. Like that gate it names every offending class and returns a fatal result, so the condition survives and Crossplane holds the cluster's resources rather than collecting them. Towards modelplaneai#603. Signed-off-by: Nicholas Thomson <RedbackThomson@users.noreply.github.com>
compose-inference-cluster composed the ClusterProviderConfig that reaches a provisioned cluster only while the cloud cluster XR was Ready. A cloud cluster XR is unready whenever any resource it composes is, so one node group or Helm release going unready on a running cluster dropped the ClusterProviderConfig from desired state, and Crossplane would delete it while every Object on the cluster still used it: the namespaces, PoolObservations, ModelReplicas and ModelRoutes. Once composed, the ClusterProviderConfig is now kept for as long as it is observed, the way the ServingStack already is. Towards modelplaneai#603. Signed-off-by: Nicholas Thomson <RedbackThomson@users.noreply.github.com>
Contributor
Author
|
Folded into #607. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Towards #603.
Two bugs in
compose-inference-clusterthat the stage conditions in #603 build on.When a node pool's class had no provisioning block for the cluster's cloud, the builder set
ClusterReady=Falsewith reasonInvalidNodePooland returned, but a laterClusterReady=Provisioningon the same reconcile replaced it, so only a Warning event said what was wrong. The early return also left the cloud cluster XR out of desired state, so Crossplane would try to delete a running cluster whose shared class lost its block. The check is now a fatal gate besidecheck_devices_supported, before any cloud is composed, naming every offending class.The kubeconfig
ClusterProviderConfigwas composed only while the cloud cluster XR was Ready. One node group or Helm release going unready on a running cluster dropped it from desired state while every Object on the cluster still used it. It's now kept for as long as it's observed, the way the ServingStack already is.I have:
nix flake check(or./nix.sh flake check) and made sure it passes.git commit -s.