perf: ensure partial cache can be re-used also when stop_index is None#413
Open
efredriksson-modelon wants to merge 1 commit into
Open
perf: ensure partial cache can be re-used also when stop_index is None#413efredriksson-modelon wants to merge 1 commit into
efredriksson-modelon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR is to speedup when using get_variable_data method without any pagination. The main speedup is to not have to re-read the time vectors for each call.
Motivation
The original guard rejected all stop_index=None cache hits. That was overly broad: it correctly blocked a partial cache being returned as a full trajectory, but it also unnecessarily blocked a genuine full trajectory in cache from being reused. The fix narrows the rejection to only the case that actually matters — cached length doesn't match the total number of available points — which is the precise condition under which returning the cache would truncate the result.