You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now I've worked on 44 examples {Electrical.Machines, Electrical.PowerConverters, Magnetic.FundamentalWave, Magnetic.QuasiStatic.FundamentalWave, Thermal.HeatTransfer} with size of ReferenceResult greater 10 MiB in 4 PRs: #4775#4787#4788#4789 (this one), reducing the size to 11.3%.
Thanks @maltelenz for updating the annotations in ModelicaTest.
I kindly ask the reviewers to inspect so we can proceed.
I'm unsure whether we could miss a regression: @henrikt-ma@maltelenz I remember discussions about "extra spikes" in PowerConverters.
The example in MSL compares only two signals over the whole simulation time.
The example in ModelicaTest compares all signals but only over a short time window.
FYI: I'll be off for some time due to health reasons, don't know exactly when I'll be back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reducing the size of Reference Results
Similar procedure as #4775 and #4787 and #4788