Skip to content

[v1.x] docs: point the README at v2 and say what v1.x supports - #2942

Open
claude[bot] wants to merge 1 commit into
v1.xfrom
docs/readme-banner-v1x
Open

claude[bot] wants to merge 1 commit into
v1.xfrom
docs/readme-banner-v1x

Conversation

@claude

@claude claude Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Requested by Felix Weinberger · Slack thread

Before: the README did not say that v1.x is the maintenance line or point readers at v2.

After: a banner under the title says v1.x implements the spec up to 2025-11-25, that the 2026-07-28 spec is in v2 (packages, docs and migration guide linked), and how long v1.x gets fixes; the licence badge links to this branch's LICENSE and the spec link names 2025-11-25.

README only, no changeset.

🤖 Generated with Claude Code

https://claude.ai/code/session_012VRbFCp41otcScXE1YY3es


Generated by Claude Code

A banner at the top says this is the maintenance line, that it implements the spec up to 2025-11-25, that the 2026-07-28 spec is not planned for v1.x and lives in v2, and how long v1.x gets fixes. The licence badge now links to this branch's LICENSE, and the spec link names 2025-11-25 instead of the draft.
@claude
claude Bot requested a review from a team as a code owner October 2, 2026 19:23
@changeset-bot

changeset-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 107e66d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@modelcontextprotocol/sdk@2942

commit: 107e66d

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Since the banner makes several claims about v2 that can't be checked from this repo, a maintainer's confirmation of those facts would still be worthwhile.

What was reviewed:

  • The "spec up to 2025-11-25" claim matches LATEST_PROTOCOL_VERSION in src/types.ts; the Overview link now points at the dated spec instead of draft, which is more accurate for a maintenance line even though src/spec.types.ts is generated from the draft schema.
  • The LICENSE badge now links to blob/v1.x/LICENSE, which is the right branch for this README; the file exists on the branch.
  • Not verifiable from the checkout: the v2 release date (2026-07-27), the six-month support window, the @ modelcontextprotocol/server / client package names, and the ts.sdk.modelcontextprotocol.io v2 and migration URLs. ROADMAP.md on this branch still describes v2 as "planned ... around mid-2026", so it may be worth a follow-up to keep the two documents consistent.
Extended reasoning...

The change is README.md only: a v1.x maintenance banner, a badge branch switch from main to v1.x, and the Overview spec link changed from draft to 2025-11-25. It touches no code and no security-sensitive surface. The in-repo facts are consistent (LATEST_PROTOCOL_VERSION is 2025-11-25, package.json is 1.32.0, CLAUDE.md describes the branch as the maintenance line). Deferring rather than approving because .github/CODEOWNERS assigns every path to the typescript-sdk team, and the banner's external claims (v2 release date, support window, package names, doc URLs) cannot be verified from the checkout and only a maintainer can confirm them.

@claude claude Bot added the v1 Issues / PRs related to v1.x label Oct 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 Issues / PRs related to v1.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant