fix(server,client): use the cf-worker validator on Node when code generation is disallowed - #2941
Open
mertcanaltin wants to merge 1 commit into
Open
mertcanaltin wants to merge 1 commit into
mertcanaltin wants to merge 1 commit into
Conversation
…eration is disallowed
🦋 Changeset detectedLatest commit: 5eacc18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Node runs with
--disallow-code-generation-from-strings, the server crashes on startup with an EvalError, because the node shim always picks Ajv and Ajv uses new Function. The workerd and browser shims already use the cf-worker validator, so I made the node shim fall back to it when new Function isn't allowed. Nothing changes for normal Node. Added tests for both packages and checked it with the real flag.