fix OIDC discovery for issuers with trailing slash - #506
Open
karedum wants to merge 1 commit into
Open
Conversation
karedum
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
September 12, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the original OIDC issuer for issuer validation and use a separate value without the trailing slash when constructing discovery URLs.
Motivation and Context
OidcDiscovery::fetchMetadata() currently removes the trailing slash from the configured issuer before performing discovery. The normalized value is also used for issuer validation.
This causes discovery to fail when the authorization server uses a trailing slash as part of its canonical issuer, such as Authentik.
OpenID Connect Discovery requires a terminating slash to be removed when constructing the discovery URL, while issuer validation must preserve the issuer identifier.
How Has This Been Tested?
Tested against an Authentik OAuth2/OpenID Connect provider whose issuer contains a trailing slash.
The existing test suite also passes locally.
Breaking Changes
None expected. Discovery URLs are constructed as before; the change only preserves the originally configured issuer for exact issuer validation.
Types of changes
Checklist