Repository navigation
fix(session): initialize data lazily in save() to prevent uninitialized property access - #252
Merged
Conversation
…ed property access
soyuka
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
March 4, 2026 17:06
Contributor
Author
|
If someone can re-run the pipeline it'd be lovely :) |
1 task done
vitek-rostislav
added a commit
to shopsys/shopsys
that referenced
this pull request
Jul 31, 2026
- fixes the production error "Typed property Mcp\Server\Session\Session::$data must not be accessed before initialization" - see the fix in mcp/sdk 0.5.0+ (modelcontextprotocol/php-sdk#252) - removed the mcp.discovery.scan_dirs prepend, file-based discovery was replaced by container registration of #[McpTool] attributed services - set http.allowed_hosts: false, the DNS rebinding protection introduced in 0.11 defaults to localhost-only and would block the public MCP endpoint, which is protected by OAuth tokens instead
vitek-rostislav
added a commit
to shopsys/shopsys
that referenced
this pull request
Aug 4, 2026
- fixes the production error "Typed property Mcp\Server\Session\Session::$data must not be accessed before initialization" - see the fix in mcp/sdk 0.5.0+ (modelcontextprotocol/php-sdk#252) - removed the mcp.discovery.scan_dirs prepend, file-based discovery was replaced by container registration of #[McpTool] attributed services - set http.allowed_hosts: false, the DNS rebinding protection introduced in 0.11 defaults to localhost-only and would block the public MCP endpoint, which is protected by OAuth tokens instead
ShopsysBot
pushed a commit
to shopsys/mcp
that referenced
this pull request
Aug 4, 2026
- fixes the production error "Typed property Mcp\Server\Session\Session::$data must not be accessed before initialization" - see the fix in mcp/sdk 0.5.0+ (modelcontextprotocol/php-sdk#252) - removed the mcp.discovery.scan_dirs prepend, file-based discovery was replaced by container registration of #[McpTool] attributed services - set http.allowed_hosts: false, the DNS rebinding protection introduced in 0.11 defaults to localhost-only and would block the public MCP endpoint, which is protected by OAuth tokens instead
ShopsysBot
pushed a commit
to shopsys/project-base
that referenced
this pull request
Aug 4, 2026
- fixes the production error "Typed property Mcp\Server\Session\Session::$data must not be accessed before initialization" - see the fix in mcp/sdk 0.5.0+ (modelcontextprotocol/php-sdk#252) - removed the mcp.discovery.scan_dirs prepend, file-based discovery was replaced by container registration of #[McpTool] attributed services - set http.allowed_hosts: false, the DNS rebinding protection introduced in 0.11 defaults to localhost-only and would block the public MCP endpoint, which is protected by OAuth tokens instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the code is self-explanatory