-
Notifications
You must be signed in to change notification settings - Fork 248
chore(deps): bump the ktor group with 15 updates #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/gradle/ktor-c466d55401
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: Ktor 3.6.0 breaks SSE streaming under
testApplication.Problem — In 3.6.0 the test host no longer hands the response to the client until the response body completes. An MCP SSE stream never completes by design, so
prepareGet(...).execute { }against an SSE endpoint blocks forever instead of entering the lambda. The regression is confined toktor-server-test-host; real engines are unaffected, so this is a test-harness break rather than an SDK defect.Failure scenario — 8 of 228
:kotlin-sdk-server:jvmTesttests hang for 60s and fail withUncompletedCoroutinesError:KtorRouteExtensionsTest(×3),StreamableHttpServerTransportTest(×3),KtorApplicationExtensionsTest,SseServerTransportTest. That is exactly whatBuild (Linux Tests)is currently red on. Reproduced locally with the version as the only variable: the same 8 fail on 3.6.0, all 228 pass on 3.5.2. Reduced further — atestApplicationthat installsSSE+mcp()and callsclient.prepareGet("/").execute { }never enters the lambda on 3.6.0 (60s timeout), while on 3.5.2 it reads theendpointevent and finishes in ~3s.Suggested fix — Hold at 3.5.2 and report upstream; the likely culprit is KTOR-8705 / ktorio/ktor#5868, which changed the channel writer's coroutine context in
TestApplicationResponse. Let Dependabot retry once a 3.6.x carries the fix. Taking 3.6.0 now would instead require porting the SSE tests offtestApplicationonto a realembeddedServer(CIO)on an ephemeral port — a change too large to ride along in a dependency bump.