-
Notifications
You must be signed in to change notification settings - Fork 248
chore(deps): bump io.ktor:ktor-bom from 3.5.2 to 3.6.0 in /samples/kotlinlang-mcp-server #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/gradle/samples/kotlinlang-mcp-server/io.ktor-ktor-bom-3.6.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem:
kotlinlang-mcp-serveris missing from thematrix.samplelists in both.github/workflows/samples.ymland.github/workflows/build.yml(each lists onlykotlin-mcp-client,kotlin-mcp-server,simple-streamable-server,weather-stdio-server). No CI job ever compiles or tests this sample, so every green check on this PR covers code the PR does not touch, and the one line it does change is unverified.Failure scenario: the Ktor 3.5.2 → 3.6.0 minor touches ContentNegotiation (
Acceptentries withq=0are now rejected), auth, and SSE. If it breaks compilation or the Streamable HTTP endpoint in this sample, this PR still merges green and the breakage surfaces only when someone clones the sample — the same blind spot the ~20 earlier dependency bumps to this directory landed through.Suggested fix: add
- kotlinlang-mcp-serverto thematrix.samplelist in.github/workflows/samples.ymland.github/workflows/build.yml(a follow-up PR is fine — the sample's unit tests use mocked HTTP clients andMapApplicationConfig, so no Algolia secrets are needed for./gradlew build). Until that lands, run./gradlew buildinsamples/kotlinlang-mcp-serverlocally before merging this bump.Non-blocking.