Fix warnings: DeprecationWarning and prints use warnings.warn.#22
Open
irm-codebase wants to merge 1 commit into
Open
Fix warnings: DeprecationWarning and prints use warnings.warn.#22irm-codebase wants to merge 1 commit into
irm-codebase wants to merge 1 commit into
Conversation
Contributor
Author
|
@jnnr: I experienced some issues when testing locally. The The change should be benign, it does not touch core logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR with some fixes:
printmessages indisaggregate.pynow use python'swarnsostderrcatches them.DeprecationWarningwas a "dead" case due to the use ofraise, later code was unreachable. It is now a warning of the correct type, so the code continues, implementing the fix after the warning.**/tmp/*to.gitignoreso test code files do not show up ingit.