Skip to content

DOC: Add artifact-cleaning note to epoch quality example.#13827

Open
1himan wants to merge 3 commits intomne-tools:mainfrom
1himan:issue-13826
Open

DOC: Add artifact-cleaning note to epoch quality example.#13827
1himan wants to merge 3 commits intomne-tools:mainfrom
1himan:issue-13826

Conversation

@1himan
Copy link
Copy Markdown
Contributor

@1himan 1himan commented Apr 9, 2026

Reference issue (if any)

Fixes #13826

No changelog needed, since its just a minor improvement 🤔?

Copy link
Copy Markdown
Contributor

@tsbinns tsbinns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1himan for opening!
I think it would be nice to really stress this by adding it as a sphinx admonition, potentially with a title like "Repairing and retaining epochs with artifacts".

@1himan
Copy link
Copy Markdown
Contributor Author

1himan commented Apr 12, 2026

Thanks @1himan for opening! I think it would be nice to really stress this by adding it as a sphinx admonition, potentially with a title like "Repairing and retaining epochs with artifacts".

Okay, now it looks something like this:
image

Copy link
Copy Markdown
Contributor

@tsbinns tsbinns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just shifted the wording a little. Test failure is unrelated.
Thanks @1himan!

@tsbinns tsbinns enabled auto-merge (squash) April 13, 2026 17:33
auto-merge was automatically disabled April 14, 2026 09:56

Head branch was pushed to by a user without write access

@1himan 1himan requested a review from larsoner as a code owner April 14, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add note to epoch quality example

3 participants