ENH: broaden OPM coil handling for colocated topomaps#13825
Open
PragnyaKhandelwal wants to merge 5 commits intomne-tools:mainfrom
Open
ENH: broaden OPM coil handling for colocated topomaps#13825PragnyaKhandelwal wants to merge 5 commits intomne-tools:mainfrom
PragnyaKhandelwal wants to merge 5 commits intomne-tools:mainfrom
Conversation
PragnyaKhandelwal
requested review from
agramfort,
drammock and
larsoner
as code owners
PragnyaKhandelwal
force-pushed
the
enh-opm-topomap
branch
from
701582b to
ef5d5a2
Compare
Contributor
Author
|
ci failure seems unrelated to this PR. Happy to iterate on this whenever you have time to review. |
Member
|
This looks reasonable to me. To help with future compat I think it's worth adding a comment to |
Contributor
Author
|
Hi @larsoner, I’ve addressed your suggestion of adding the comment in the |
Contributor
Author
|
Updated branch with main..all checks passed..ready to merge... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Related to #13781
Hi @larsoner, @drammock
I tried to start with a small incremental fix to keep the scope reviewable and testable. This branch now handles
colocated OPMtopomap detection more robustly, and I’ll continue with the orientation-grouping part next once I get guidance on the preferred direction.