-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MAINT: Modernize path handling in misc.py using pathlib #13775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Akhila21-6
wants to merge
21
commits into
mne-tools:main
Choose a base branch
from
Akhila21-6:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−374
Open
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0b1ecb8
MAINT: Modernize path handling in misc.py using pathlib
Akhila21-6 820f7ad
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1322a09
Merge branch 'main' into main
Akhila21-6 416be7c
MAINT: Add changelog entry for #13775
Akhila21-6 7f5b6c4
Merge branch 'main' of https://github.com/Akhila21-6/mne-python
Akhila21-6 1d50715
Update mne/misc.py
Akhila21-6 0cdfea7
Update mne/misc.py
Akhila21-6 88d3ee9
Update mne/misc.py
Akhila21-6 71bb006
Update mne/misc.py
Akhila21-6 fb3fc60
Update mne/misc.py
Akhila21-6 b0d4b42
MAINT: Add changelog entry
Akhila21-6 ba1b693
Merge branch 'main' of https://github.com/Akhila21-6/mne-python
Akhila21-6 c6e3afa
Merge branch 'main' into main
Akhila21-6 c6e3cc4
MAINT: move changelog to dev/ and add contributor name
Akhila21-6 70f9fac
Merge branch 'main' of https://github.com/Akhila21-6/mne-python
Akhila21-6 cd25ecf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 197de22
MAINT: fix names.inc syntax and verify dev path
Akhila21-6 58535a7
Merge branch 'main' into main
Akhila21-6 9a386c5
MAINT: fix docs syntax and resolve rebase
Akhila21-6 3c982e9
MAINT: Restore names.inc and fix contribution syntax
Akhila21-6 9a79553
MAINT: restore names.inc and use newcontrib syntax
Akhila21-6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Modernized path handling in :func:mne.viz.parse_config and :func:mne.viz.read_reject_parameters to use pathlib, by Akhila Thammenenwar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Modernize path handling in ``mne/misc.py`` using ``pathlib``, by `Akhila Thammenenwar`_. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added two changelog entries. The syntax in this file is correct but it should go in
doc/changes/dev/.Also please add your name and public profile to
doc/changes/names.inc