Repository navigation
Fix names in eBPF scripts - #1624
Merged
Merged
Conversation
We renamed the eBPF trace point `process_root_nodes` to `process_pinning_roots` before, but didn't rename the eBPF scripts. This revision fixes that. Considering that some VM bindings may not use `harness_begin` and `harness_end`, those trace points may not exist in the VM executable or library. We only set up those trace points when the `-H` command line option is added to `capture.py`.
qinsoon
approved these changes
Oct 28, 2026
qinsoon
left a comment
qinsoon
left a comment
Member
There was a problem hiding this comment.
LGTM
We could consider adding a CI check for the eBPF scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We renamed the eBPF trace point
process_root_nodestoprocess_pinning_rootsbefore, but didn't rename the eBPF scripts. This revision fixes that.Considering that some VM bindings may not use
harness_beginandharness_end, those trace points may not exist in the VM executable or library. We only set up those trace points when the-Hcommand line option is added tocapture.py.