Fix broken nav2 install-script link in the navigation section - #37
Merged
Merged
Conversation
The navigation installation section pulled install_nav2.sh from UoMMScRobotics/SFR_Gazebo, which now returns a 404. Point the literalinclude at the repository's own docker/gazebo_nav2/install_nav2.sh, mirroring how the Gazebo section references its install_gazebo.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navigation installation section (
docs/source/navigation/installation.rst) included the nav2 install script from:which now returns 404 (so the section couldn't display/run the install commands, and the build emitted a Sphinx warning).
Fix
Point the include at the repository's own
docker/gazebo_nav2/install_nav2.sh, mirroring exactly how the Gazebo section already references its siblingdocker/gazebo_nav2/install_gazebo.sh:The local file already contains the full
apt-get installsequence the doc intends to show, so:lines: 5-14is unchanged and the rendered output is preserved.Verification
404/SFR_Gazebowarning is gone; noSFR_Gazeboreferences remain in the built docs.ros-jazzy-navigation2/ros-jazzy-nav2-bringup/ros-jazzy-nav2-minimal-tb*/ros-jazzy-slam-toolboxcommands.