Spec, changelog, and docstring corrections after the burn-down batch - #144
Merged
Merged
Conversation
The spec's architecture tree lists creature.py, its reading-state section describes the typed referee view, and its battle sentences name the magic-phase re-check and the formation rule, which the batch left it silent on. The disruption sentence covers a refused re-check as well as a blow. Two changelog clauses read as a whole release's notes: the protocol bullet says what a type checker now refuses instead of calling a narrowing a widening, and the referee view bullet scopes its schema claim to its own change, since the same section moves SCHEMA_VERSION to 4. The _party_magic docstring names the two declaration kinds the re-check covers rather than every declaration. Claude-Session: https://claude.ai/code/session_01NmCezTw8hKKujkaEZ3YGAs
osr-web hands the result to has_condition, which now takes a Creature, so the object annotation failed its pyright run. The method already documented the two types it returns. Claude-Session: https://claude.ai/code/session_01NmCezTw8hKKujkaEZ3YGAs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections the batch-wide integration review found:
docs/spec.mdgainscreature.pyin the architecture tree, the typed referee view under reading state, and the magic-phase re-check and the formation rule in the battle sentences; the disruption sentence covers a refused re-check; two changelog clauses are scoped to what they describe; the_party_magicdocstring names the two declaration kinds the re-check covers. Full gate green.https://claude.ai/code/session_01NmCezTw8hKKujkaEZ3YGAs